fix: nested MCP cleanup error redaction - #4049
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes credential-bearing HTTPX errors nested inside MCP cleanup exception groups escaping the transport redaction boundary.
Cleanup recursively detects unsafe HTTPX errors without changing the established handling of safe nested groups. Unsafe groups are omitted from log records and mapped error causes, while safe nested groups retain their original error level, complete exception diagnostics, and non-HTTP sibling failures.
The regression coverage verifies redacted and diagnostic modes, mixed safe and unsafe groups, exception and traceback retention, safe group preservation, cancellation behavior, and cleanup state clearing.